Re: [PATCH 4/4] staging: vt6656: Remove typedef enum _CONTEXT_TYPE

[Malcolm Priestley <tvboxspy@xxxxxxxxx>]

On 19/02/14 22:15, Joe Perches wrote:
> On Wed, 2014-02-19 at 21:56 +0000, Malcolm Priestley wrote:
> > Replace with enum
> > assign as u8 type.
> []
> > diff --git a/drivers/staging/vt6656/device.h b/drivers/staging/vt6656/device.h
> []
> > @@ -180,7 +180,7 @@ struct vnt_usb_send_context {
> >   	struct sk_buff *pPacket;
> >   	struct urb *pUrb;
> >   	unsigned int uBufLen;
> > -	CONTEXT_TYPE Type;
> > +	u8 type;
>
> This doesn't really save any space in the struct.
> You might move it immediately before or after bBoolInUse.
>
> >   	struct ethhdr sEthHeader;
> >   	void *Next;
> >   	bool bBoolInUse;
No, but there are dead members in the structure that need removing.

sEthHeader and Next are dead


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html