Search Linux Wireless

Re: [RFC/RFT 4/7] ath10k: bypass htc for htt tx path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michal Kazior <michal.kazior@xxxxxxxxx> writes:

> Going through full HTC tx path for HTT tx is a
> waste of resources. By skipping it it's possible
> to easily submit scatter-gather to the PCI HIF for
> reduced host CPU load and improved performance.
>
> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx>

For a change like this the commit log needs to be more descriptive.
There's no mention about dma pools, nothing about the basic principle
how this works now etc.

> @@ -1067,9 +1067,9 @@ struct ath10k_ce_pipe *ath10k_ce_init(struct ath10k *ar,
>  	 *
>  	 * For the lack of a better place do the check here.
>  	 */
> -	BUILD_BUG_ON(TARGET_NUM_MSDU_DESC >
> +	BUILD_BUG_ON(2*TARGET_NUM_MSDU_DESC >
>  		     (CE_HTT_H2T_MSG_SRC_NENTRIES - 1));
> -	BUILD_BUG_ON(TARGET_10X_NUM_MSDU_DESC >
> +	BUILD_BUG_ON(2*TARGET_10X_NUM_MSDU_DESC >
>  		     (CE_HTT_H2T_MSG_SRC_NENTRIES - 1));
>  
>  	ret = ath10k_pci_wake(ar);
> diff --git a/drivers/net/wireless/ath/ath10k/ce.h b/drivers/net/wireless/ath/ath10k/ce.h
> index 322e929..8eb7f99 100644
> --- a/drivers/net/wireless/ath/ath10k/ce.h
> +++ b/drivers/net/wireless/ath/ath10k/ce.h
> @@ -23,7 +23,7 @@
>  
>  /* Maximum number of Copy Engine's supported */
>  #define CE_COUNT_MAX 8
> -#define CE_HTT_H2T_MSG_SRC_NENTRIES 2048
> +#define CE_HTT_H2T_MSG_SRC_NENTRIES 4096

Also document why you do these changes.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux