On Fri, Feb 14, 2014 at 01:01:00PM +0100, Rafał Miłecki wrote: > 2014-02-14 0:34 GMT+01:00 Hauke Mehrtens <hauke@xxxxxxxxxx>: > > On 02/13/2014 06:06 PM, Rafał Miłecki wrote: > >> Broadcom boards have 32 GPIOs (not 16) and these higher ones are > >> actually used on some devices (for buttons, reset of WiFi devices). > >> > >> Signed-off-by: Rafał Miłecki <zajec5@xxxxxxxxx> > >> --- > >> Similar patch may be needed for ssb, however I didn't meet any ssb SoC > >> with GPIOs 16-31 connected to anything. > >> This is so trivial I hope it can go as a fix for 3.14. It allows support > >> for some devices that use these higher GPIOs. > >> --- > >> drivers/bcma/driver_gpio.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > Are you sure all the bcma SoC have 32 GPIO lines or is there no problem > > when they do not? For at least some ssb based SoCs I know that they only > > have 16 GPIO lines. > > Damn, I'm afraid you may be right. I didn't think about that. > > I was able to find references to GPIOs 16-31 on BCM5357 based boards only. Sounds like I need to revert that patch. Please never, _ever_, post a patch (no matter how trivial) for the stable tree unless you are absolutely sure about it in the first place. John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
