Michal Kazior <michal.kazior@xxxxxxxxx> writes: > On 10 February 2014 18:13, Marek Puzyniak <marek.puzyniak@xxxxxxxxx> wrote: >> Wmi command WMI_FORCE_FW_HANG_CMDID is not supported >> in firmware 10.1. In order to have firmware crash simulation >> functionality also in firmware 10.1 driver can force firmware >> crash by performing not allowed operation. Driver can deliberately >> crash firmware when setting vdev param for vdev id out of range. >> >> Command to trigger firmware crash: >> echo "crash" > /sys/kernel/debug/ieee80211/phyX/ath10k/simulate_fw_crash >> >> Signed-off-by: Marek Puzyniak <marek.puzyniak@xxxxxxxxx> >> --- > > The 'fw hang assert' crash can be recovered with a warm reset but a > real crash can't. Oh, I didn't know that. > Thus, I think the two crash methods should be distinguishable Yeah, I agree. > by having either two separate debugfs files or two separate trigger > keywords. I think having a keyword would be a better to way differentiate these. And if the firmware doesn't support WMI_FORCE_FW_HANG_ASSERT, then just return -EOPNOTSUPP. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
