On Thu, 2014-02-13 at 11:46 +0100, Simon Wunderlich wrote: Hi Simon > > On Wed, 2014-02-12 at 11:53 +0100, Simon Wunderlich wrote: > > > MPLS labels may contain traffic control information, which should be > > > evaluated and used by the wireless subsystem if present. [] > > > diff --git a/net/wireless/util.c b/net/wireless/util.c [] > > > +#include <uapi/linux/mpls.h> > > > > Please try not to #include uapi files. > why not? The packet definition header has been put in UAPI, so I need that > there ... or should we move that to some place else? Other protocol definition > headers like IP, udp, tcp have been defined in uapi to the same way, so I > figured that would be the right position. It seems the practice is to have another include/<net|linux>/mpls.h file that #includes the <uapi/linux/mpls.h> For instance, look at: include/linux/udp.h It does #include <uapi/linux/udp.h> All the other kernel sources use #include <linux/udp.h> -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html