On 2014-02-05 22:57, Johannes Berg wrote: > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > NAPI was originally added to mac80211 a long time ago (by John in > commit 4e6cbfd09c66 in July 2010), but then removed years later > (by Stanislaw in commit 30c97120c6c7 in February 2013). No driver > ever used it, so that was fine. > > Now I'm adding support for NAPI to our driver, so add some code > to mac80211 again to support NAPI. John was originally wrapping > some (but not nearly all NAPI-related functions), but that doesn't > scale very well with the number of functions there there are, some > of which are even only inlines. Thus, instead of doing that, let > the drivers manage the NAPI struct, except for napi_add() which is > needed so mac80211 knows how to call napi_gro_receive(). Why do you call napi_gro_receive at all? Without device GRO support it seems to be just a fancy way of doing netif_receive_skb with a bit more unnecessary indirection. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
