Search Linux Wireless

Re: [RFC 1/2] mac80211: merge STA CSA code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3 February 2014 14:18, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Mon, 2014-02-03 at 10:58 +0100, Michal Kazior wrote:
>> + * @timestamp: value in microseconds of the 64-bit Time Synchronization
>> + *   Function (TSF) timer when the frame containing the channel switch
>> + *   announcement was received. This is simply the rx.mactime parameter
>> + *   the driver passed in.
>
> That doesn't make a lot of sense, since "rx.mactime" is a mac80211
> thing, so you should probably describe this. I'm not sure it really
> needs to be mactime/TSF, does that even make sense? It seems more likely
> you'd actually need the device time, i.e. something that works across
> multiple vifs?
>
> Not sure this even belongs into this patch anyway though?

It does belong here. How else are you supposed to pass the timestamp
for STA CSA offload?

Would making this sort of a drv_priv thing work?

If we could just kill the offload, adding timestamp to
cfg80211_csa_settings wouldn't be necessary.


Michał
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux