Search Linux Wireless

Re: [PATCH 18/18] mac80211: enable mesh in Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-02-25 at 12:58 -0800, Luis Carlos Cobo wrote:
> On Sat, 2008-02-23 at 15:17 +0100, Johannes Berg wrote:
> > Currently marked BROKEN because of endianness problems.
> 
> Will take care of those problems.

Oh this reminds me.

You have a lot of macros like

#define PREQ_IE_ORIG_DSN(x) le32_to_cpu(*((u32 *) (x + 13)))

Would it be possible to define the preq IE as a struct? Not sure if it
is. Either way, this should be converted to a static inline instead of a
macro.

Also, you need to add a lot of get_unaligned() to the code. Please read
Daniel's excellent Documentation/unaligned-memory-access.txt

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux