Search Linux Wireless

Re: [PATCH 05/13] ath9k_htc: add rx header converter to make it usable by ath9k

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oleksij Rempel wrote:
> +	rx_stats = kzalloc(sizeof(struct ath_rx_status), GFP_KERNEL);
> +	if (unlikely(rx_stats == NULL)) {
> +		ath_err(common, "rx_stats allocation filed!\n");
> +		goto err_nofree;
> +	}
> +	rx_status_htc_to_ath(rx_stats, &rxbuf->rxstatus);
> +

This seems a little expensive, since this would happen for every packet,
and a memcpy is already done earlier, for storing the RX status in
rxbuf->rxstatus. Instead of using 'struct ath_htc_rx_status' in
'struct ath9k_htc_rxbuf', why can't 'struct ath_rx_status' be used ?
The values can be converted and stored directly, avoiding this alloc.

Sujith

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux