Sorry, I had somehow lost this patch before.
> + if (params->opmode_notif_used) {
> + enum ieee80211_band band =
> + ieee80211_get_sdata_band(sdata);
> + ieee80211_vht_recalc_handle_opmode(sdata, sta,
> + params->opmode_notif,
> + band, 0);
> + }
That last argument should be 'false', it seems. You're also ignoring the
return value, which seems wrong at first look? Maybe it's right, but
then you should probably add a comment?
> +u32 ieee80211_vht_recalc_handle_opmode(struct ieee80211_sub_if_data *sdata,
> + struct sta_info *sta, u8 opmode,
> + enum ieee80211_band band, bool nss_only);
> void ieee80211_vht_handle_opmode(struct ieee80211_sub_if_data *sdata,
> struct sta_info *sta, u8 opmode,
> enum ieee80211_band band, bool nss_only);
It's not clear to me what those function name distinction means, maybe
it would be better to not call this 'recalc' but just give it two
underscores in the function name or so, since it's really the same but
without calling the RC upate?
> - struct ieee80211_local *local = sdata->local;
> - struct ieee80211_supported_band *sband;
> enum ieee80211_sta_rx_bandwidth new_bw;
> - u32 changed = 0;
> u8 nss;
> -
> - sband = local->hw.wiphy->bands[band];
> + u32 changed = 0;
Why change the order of nss/changed? If you leave as is the diff might
be simpler? Not that it matters, I was just wondering for a bit here
what was really changed on the 'changed' line.
> sta->sta.bandwidth = new_bw;
> changed |= IEEE80211_RC_BW_CHANGED;
> }
> + return changed;
Would prefer a blank line after the }
> +void ieee80211_vht_handle_opmode(struct ieee80211_sub_if_data *sdata,
> + struct sta_info *sta, u8 opmode,
> + enum ieee80211_band band, bool nss_only)
> +{
> + struct ieee80211_local *local = sdata->local;
> + struct ieee80211_supported_band *sband = local->hw.wiphy->bands[band];
> + u32 changed = ieee80211_vht_recalc_handle_opmode(sdata, sta, opmode,
> + band, nss_only);
> + if (changed > 0)
And after the variable declarations, i.e. before the if
Sorry for the delay, not sure why I missed your patch!
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
