Search Linux Wireless

Re: [PATCH 3.13.1 3/9] rsi: Packet queueing/dequeueing to device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2014-01-30 at 21:24 +0530, Jahnavi wrote:

> +#ifdef USE_SDIO_INTF
> +static unsigned int pkt_count;
> +#endif
> +static unsigned int selected_qnum, pkt_cnt;

static variables are a really bad idea, especially ones like this. Have
you ever thought about more than one USB device being plugged in to the
same machine? :)

Also, I'm not sure trying to implement QoS in software is a great idea,
or does it only look like that's what you're doing?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux