Thanks again,
Ilan.
> > +/*
> > + * State variable indicating if the platform on which the devices
> > + * are attached is operating in an indoor environment. The state
> > +variable
> > + * is relevant for all registered devices.
> > + * Note: currently not protected by any synchronization primitive.
> > + */
> > +static bool reg_is_indoor;
> > +
>
> See if it makes sense to instead start building up a single reg data structure
> that has a slew of members. That's welcomed as a separate patch later...
>
Sure. Will have a look at this.
> > @@ -1475,6 +1493,11 @@ reg_process_hint_user(struct
> regulatory_request *user_request)
> > return treatment;
> > }
> >
> > + if (reg_request_indoor(user_request) && treatment ==
> REG_REQ_OK) {
> > + reg_is_indoor = true;
> > + return REG_REQ_OK;
> > + }
> > +
>
> Are you setting this to false when we disconnect (reset regulatory)?
> You should.
>
I wasn't. Fixing.
> > @@ -1658,9 +1681,6 @@ static void reg_process_hint(struct
> regulatory_request *reg_request)
> > struct wiphy *wiphy = NULL;
> > enum reg_request_treatment treatment;
> >
> > - if (WARN_ON(!reg_request->alpha2))
> > - return;
> > -
>
> last_request checks for the alpha2 are abundent... you'd have to go review
> such use cases... One strategy might be to not treat this as a pure regulatory
> request but rather a hint of information, ie, not override last_request for this
> type of request.
Actually, when the hint is processed, REG_REQ_ALREADY_SET is returned, so the request is immedialty freed, and the last request is not updated. I thought that this should suffice. Do you see any other issue with this?
> > +#endif /* CONFIG_CFG80211_REG_SOFT_CONFIGURATIONS */
>
> config_enabled() would make this look sexier.
Fixing ..
>
> > @@ -2502,6 +2551,8 @@ int __init regulatory_init(void)
> > user_alpha2[0] = '9';
> > user_alpha2[1] = '7';
> >
> > + reg_is_indoor = false;
>
> Yeah this is not needed as during init this will be false, but you do want to
> ensure you set this to flase during reset of regulatory.
>
> Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
