On Mon, 2008-02-25 at 11:09 -0800, Luis Carlos Cobo wrote: > On Sat, 2008-02-23 at 15:17 +0100, Johannes Berg wrote: > > This fixes missing unlocks noticed by sparse. > > Thanks for the fix. It would be easier though to just acquire the lock > later, since rcu_read_lock() is no longer needed to look for mesh peer > links, like in this patch (applied to the original version of the file > without the patch included in the mail I'm replying to). > u8 action = mgmt->u.action.u.mesh_action.action_code; > > - rcu_read_lock(); > sta = sta_info_get(local, mgmt->sa); > if (!sta) > return 0; Ah, but sta_info_get will require rcu locking after a few more patches so I now that I posted both sets this is easier (otherwise the sta info rcu-ification would have to add all the code and revert this patch) johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
