2014/1/24 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>: > On Fri, 2014-01-24 at 14:29 +0100, Janusz Dziedzic wrote: >> Set preset_chandef in channel switch notification. >> In other case we will have old preset_chandef. > > Why would we care? We only keep the preset_chandef thing around because > hostapd (currently) doesn't pass the frequency to START_AP/the first > SET_BEACON, but after that this doesn't matter. And when you shut down > hostapd, and restart it, then it'll set the preset_chandef again through > explicitly setting the channel. > > So in which case would we care? Who would ever STOP_AP and then START_AP > without a new frequency? > We have test code in cfg80211 that using preset_chandef when compare chandefs when csa. And after that I see we never change preset_chandef after csa. >From other side, I could imagine case where we have two VAPs in hostapd. - first we start first VAPs (eg. channel 36 HT40+) - next we call CSA (channel 44 HT40+) - now we start second VAPs - we will get err here because of preset_chandef (36 HT40+) BR Janusz -- Janusz Dziedzic -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
