On Fri, 2014-01-24 at 20:08 +0800, Fengguang Wu wrote:
> Hi Johannes,
>
> The BUG does not show up in linux-next 20140124, is it fixed now?
It isn't in linux-next yet I believe (mac80211-next isn't in there), but
yeah, I fixed it already, ran into it myself yesterday. Hope it didn't
cause you too much trouble. The problem was that I misplaced some code
because I didn't notice that the if () condition (see below) had no
braces.
I replaced that commit with
commit 091a69f86862454c282d4a64c9d66074e60514ea
Author: Johannes Berg <johannes.berg@xxxxxxxxx>
Date: Wed Jan 22 10:36:59 2014 +0100
mac80211: remove module handling from rate control ops
which now contains this change
list_for_each_entry(alg, &rate_ctrl_algs, list) {
- if (!strcmp(alg->ops->name, name))
- if (try_module_get(alg->ops->module)) {
- ops = alg->ops;
- break;
- }
+ if (!strcmp(alg->ops->name, name)) {
+ ops = alg->ops;
+ break;
+ }
}
(note the new set of braces added around the content of the strcmp if)
Sorry!
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
