Search Linux Wireless

Re: [PATCH 1/2] mac80211: Extra debug info for station cleanup case.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/22/2014 03:11 PM, Johannes Berg wrote:
> On Wed, 2014-01-22 at 14:54 -0800, greearb@xxxxxxxxxxxxxxx wrote:
>> -		WARN_ON_ONCE(ret != 0);
>> +		if (WARN_ON_ONCE(ret != 0))
>> +			sdata_info(sdata, "sta-info-destroy: drv-sta-state error: %i, sta: %pM\n",
>> +				   ret, sta->sta.addr);
> 
> You should put the string into the warning
> 
> WARN_ONCE(ret, "sta-info-destroy: ...", ...)

I wanted it to kernel splat once and print out a message, and after that, only print
messages.

I think your suggestion will only splat _and_ print once?

Thanks,
Ben

> 
> johannes
> 


-- 
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux