On Wed, 2014-01-22 at 07:36 +0100, Michal Kazior wrote: > >> + if (!attrs[NL80211_ATTR_IFINDEX]) > >> + return -EINVAL; > > > > Hmm, shouldn't you use the ifindex from the csa_attrs? Or are you > > requiring one to be in the outer data to identify the wiphy? But that > > seems odd too, you can just get the wiphy in whatever way by asking the > > pre_doit for that? > > I'm not sure I understand you. > > There are two command variants now: > > 1: the old one, which has ifindex in the root > 2: the new one, which has wiphy in the root, and an array of (1) > within CH_SWITCH_IFACES (and each entry has ifindex at its root) Yeah I think I confused the two. This is handling case 1 only, right? But you have to check the ifindex manually since for case 2 you can only require the pre_doit() to give you the wiphy. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html