Search Linux Wireless

Re: [PATCH] mac80211: mesh: fix mesh_id check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2014-01-22 at 14:45 +0800, Chun-Yeow Yeoh wrote:

> > @@ -866,7 +866,7 @@ ieee80211_mesh_process_chnswitch(struct ieee80211_sub_if_data *sdata,
> >         if (sdata->vif.csa_active)
> >                 return true;
> >
> > -       if (!ifmsh->mesh_id)
> > +       if (!ifmsh->mesh_id_len)
> 
> I don't see this in mac80211-next. Anyway, I think that this is not
> needed since the checking (sdata->wdev.mesh_id_len) is done at
> ieee80211_mesh_rx_queued_mgmt prior to
> ieee80211_mesh_process_chnswitch.

Indeed, this part seems to only be in 3.13 - probably got cleaned up in
somebody else's patches. I think though mac80211 should probably check
ifmsh->mesh_id_len and not sdata->wdev.mesh_id_len? Also, cfg80211 seems
to be missing this check in nl80211_channel_switch(), no?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux