Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> writes: > On 20 January 2014 17:59, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: >> Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> writes: >> >>> Move UAPSD params settings after peer assoc >>> command. This is required to setup UAPSD >>> params correctly. >>> >>> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> >> >> This is a pretty vague description. What is correct today can be totally >> wrong tomorrow :) >> >> So I would prefer that you describe a bit more about this change. At >> least describe the bug you are fixing (or mention the motivation behind >> the change). > > ath10k handles UAPSD completly in the firmware. > When works in AP mode we have to configure > UAPSD params for each station. Without this > patch we configure UAPSD params before we > send peer assoc command to the FW, which was > wrong. Next FW didn't know what should be trigger > frame, couse UAPSD didn't work correctly in AP mode. > To configure UAPSD params correctly we have to > send them after peer assoc command. This is much better. Can you send v2 with this description, please? -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
