Search Linux Wireless

[PATCH] mac80211: add missing "break" statement in mesh code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This inserts a missing break statement which, if hit, would cause
the code to fall-through and unlock a spinlock twice. Noticed via
sparse's "lock count wrong in basic block" warning and careful
code inspection.

Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Cc: Luis Carlos Cobo <luisca@xxxxxxxxxxx>
---
 net/mac80211/mesh_plink.c |    1 +
 1 file changed, 1 insertion(+)

--- everything.orig/net/mac80211/mesh_plink.c	2008-02-24 12:22:02.000000000 +0100
+++ everything/net/mac80211/mesh_plink.c	2008-02-24 12:22:18.000000000 +0100
@@ -691,6 +691,7 @@ void mesh_rx_plink_frame(struct net_devi
 			spin_unlock_bh(&sta->plink_lock);
 			mesh_plink_frame_tx(dev, PLINK_CLOSE, sta->addr, llid,
 					    plid, reason);
+			break;
 		case OPN_ACPT:
 			if (del_timer(&sta->plink_timer))
 				sta_info_put(sta);


-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux