Bartosz Markowski <bartosz.markowski@xxxxxxxxx> writes: > chandef does not provide 11n / 11ac split. Use the highest > phymodes for 20/40MHz channels, firmware can operate on. > > Signed-off-by: Bartosz Markowski <bartosz.markowski@xxxxxxxxx> Is this just code cleanup and or does this actually fix something? > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -256,10 +256,10 @@ chan_to_phymode(const struct cfg80211_chan_def *chandef) > phymode = MODE_11A; > break; > case NL80211_CHAN_WIDTH_20: > - phymode = MODE_11NA_HT20; > + phymode = MODE_11AC_VHT20; > break; > case NL80211_CHAN_WIDTH_40: > - phymode = MODE_11NA_HT40; > + phymode = MODE_11AC_VHT40; > break; > case NL80211_CHAN_WIDTH_80: > phymode = MODE_11AC_VHT80; But doesn't this mean that we will use, for example, MODE_11AC_VHT20 on 11n mode? I think we need to investigate how MODE_11AC_VHT20 and MODE_11NA_HT20 actually differ (and the same for 40 MHz channels). -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
