Search Linux Wireless

Re: [PATCH] nl80211: Reset split_start on error path when split dump is not used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-01-16 14:53, Johannes Berg wrote:

@@ -1680,6 +1680,7 @@ static int nl80211_dump_wiphy(struct sk_buff *skb, struct netlink_callback *cb)
   				    !skb->len &&
   				    cb->min_dump_alloc < 4096) {
   					cb->min_dump_alloc = 4096;
+					state->split_start = 0;
   					rtnl_unlock();
   					return 1;
   				}

Will that not cause problem if split scan is in use and one of the split
chunks needs to be resent due to EMSGSIZE?

That's not supposed to happen, and the "!skb->len" check should catch
it.

johannes

Ok. Thanks. Lets go for that version then.

//Pontus


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux