On Wed, 2014-01-15 at 17:10 +0100, Janusz Dziedzic wrote:
> On 15 January 2014 14:27, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> > On Wed, 2014-01-15 at 13:16 +0100, Janusz Dziedzic wrote:
> >
> >> @@ -3211,6 +3212,7 @@ struct wireless_dev {
> >>
> >> bool cac_started;
> >> unsigned long cac_start_time;
> >> + unsigned int cac_time_ms;
> >
> > Why would that need to be stored here? Isn't it just a pretty much local
> > parameter of the radar detection startup?
> >
> Because of this WARN_ON
>
> @@ -778,7 +778,7 @@ void cfg80211_cac_event(struct net_device *netdev,
> switch (event) {
> case NL80211_RADAR_CAC_FINISHED:
> timeout = wdev->cac_start_time +
> - msecs_to_jiffies(IEEE80211_DFS_MIN_CAC_TIME_MS);
> + msecs_to_jiffies(wdev->cac_time_ms);
> WARN_ON(!time_after_eq(jiffies, timeout));
>
> We have to know this if we need this warning.
Oh, ok. Is it guaranteed to not be overwritten in the meantime though? I
guess you can't start two CACs at the same time, so I guess that's ok.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
