On Tue, 2014-01-14 at 13:19 -0800, Greg KH wrote: > On Tue, Jan 14, 2014 at 09:00:08PM +0000, Malcolm Priestley wrote: > > On Mon, 2014-01-13 at 15:46 -0800, Greg KH wrote: > > > On Mon, Jan 13, 2014 at 04:29:15PM +0000, Malcolm Priestley wrote: > > > > Add missing aes_ccmp.h header and move device.h to > > > > aes_ccmp.h > > > > > > Why move device.h? > > device.h is needed by aes_ccmp.h and only currently gets away with it > > by the include order elsewhere. > > Then fix that up first. > > > I didn't see the need to include device.h twice or fix > > it with the include order in aes_ccmo.c, there is enough of > > that already in this driver. > > Fix it properly, as it will have to be resolved sometime, right? > The headers are just too tangled to fix just yet. There is still a lot of typedefs, duplicate and dead code spread across the driver that need removing first. I've just realised that aes_ccmp.c is dead code, it is part of the non functioning hostapd code in hostap.c, I am planning to remove it. Regards Malcolm > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html