Search Linux Wireless

Re: [PATCH 3/8] bcma: add agent IOCTL bit values for Broadcom 802.11 and CR4 cores

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2014/1/13 Arend van Spriel <arend@xxxxxxxxxxxx>:
> The IOCTL register in the agent/wrapper contains additional bits
> that are core specific and use in the core reset sequence.

I'm not sure about this. I don't think we want to keep device-specific
bits in a commond (bcma's) code.

For example, I can't see PCI defines (like linux/pci_regs.h) having
any device specific bits in this shared code.

Our case with bcma is a bit more tricky, because we have a single
register with common and device-specific bits at the same time. So
maybe I'll find another example.

What about USB? Let's say linux/usb/ch9.h. There is a struct
usb_ctrlrequest that has bRequestType and bRequest.
bRequestType accepts some common values like USB_DIR_IN,
USB_RECIP_INTERFACE, etc. They are defined in the same file.
bRequest values are device-specific and you don't have them defined in
the above file.
That makes pretty much sense for me.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux