Search Linux Wireless

Re: [PATCH 2/6] staging: vt6656: sparse fixes: device_get_stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 13, 2014 at 04:18:50PM +0000, Malcolm Priestley wrote:
> sparse warning
> main_usb.c:1442:44: warning: cast removes address space of expression
> 
> Signed-off-by: Malcolm Priestley <tvboxspy@xxxxxxxxx>
> ---
>  drivers/staging/vt6656/main_usb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 4cb7aa7..59c2430 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -1418,8 +1418,9 @@ static void device_set_multi(struct net_device *dev)
>  static struct net_device_stats *device_get_stats(struct net_device *dev)
>  {
>  	struct vnt_private *pDevice = netdev_priv(dev);
> +	struct net_device_stats *stats = &pDevice->stats;
>  
> -	return &pDevice->stats;
> +	return stats;

This change makes no sense to me.  Why is sparse complaining about this?

Is this a bug in sparse, or am I missing something obvious here?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux