Search Linux Wireless

Re: [PATCH] mac80211: Return untuned timestamp in case of invalid bitrates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 6, 2014 at 8:34 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Thu, 2013-12-26 at 13:42 +0000, Chaitanya Tata wrote:
>> In case the driver sends MCS9 and doesn't advertise CBW
>> (or) advertises 20MHz bandwidth, return the timestamp As is,
>> instead of returning 0 as timestamp.
>>
>> Signed-off-by: Chaitanya T K <Chaitanya.mgit@xxxxxxxxx>
>> ---
>> net/mac80211/util.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/mac80211/util.c b/net/mac80211/util.c index 06265d7..bc92b25 100644
>> --- a/net/mac80211/util.c
>> +++ b/net/mac80211/util.c
>> @@ -2265,7 +2265,7 @@ u64 ieee80211_calculate_rx_timestamp(struct ieee80211_local *local,
>>       if (WARN_ONCE(!rate,
>>                     "Invalid bitrate: flags=0x%x, idx=%d, vht_nss=%d\n",
>>                     status->flag, status->rate_idx, status->vht_nss))
>> -             return 0;
>> +             return ts;
>
> I think this is wrong - we've already warned, we know we have no usable
> timestamp, and this should never happen anyway.

Timestamp is just off by packet length (as we dont have proper MCS rates),
but still we can use it as un-rewinded timestamp.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux