Search Linux Wireless

Re: [PATCH 08/13 v2] o11s: other changes in mac80211 for mesh interface support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>  int ieee80211_set_freq(struct ieee80211_local *local, int freq);
>  /* ieee80211_sta.c */
> +#define IEEE80211_FC(type, stype) cpu_to_le16(type | stype)

That seems... misplaced.

>  	if (sdata->vif.type != IEEE80211_IF_TYPE_STA &&
>  	    sdata->vif.type != IEEE80211_IF_TYPE_IBSS &&
> +	    sdata->vif.type != IEEE80211_IF_TYPE_MESH_POINT &&
>  	    sdata->vif.type != IEEE80211_IF_TYPE_AP)
>  		return -EOPNOTSUPP;

Why no scanning on mesh interfaces?

> +struct sta_info *sta_info_get_by_idx(struct ieee80211_local *local, int idx,
> +				     struct net_device *dev)
> +{
> +	struct sta_info *sta;
> +	int i = 0;
> +
> +	read_lock_bh(&local->sta_lock);
> +	list_for_each_entry(sta, &local->sta_list, list) {
> +		if (i < idx) {
> +			++i;
> +			continue;

I already commented on the raciness of this.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux