Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> writes: > Add set_bitrate_mask callback. Currently > ath10k HW is limited to handle only single > fixed rate setting or limit number of used > spatial streams. > > Example: > iw wlanX set bitrates legacy-5 ht-mcs-5 vht-mcs-5 2:9 > will setup VHT, nss=2, mcs=9 > > iw wlanX set bitrates legacy-5 18 ht-mcs-5 vht-mcs-5 > will setup legacy, 18Mbps > > iw wlanX set bitrates legacy-5 ht-mcs-5 3 vht-mcs-5 > will setup HT, nss=1, mcs=3 > > iw wlanX set bitrate legacy-5 ht-mcs-5 vht-mcs-5 1:0-9 > will setup nss=1 > > iw wlanX set bitrate legacy-5 ht-mcs-5 vht-mcs-5 1:0-9 2:0-9 > will setup nss=2 > > Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> I see a new warning with this patch: ath10k/mac.c:3593:52: error: unknown field name in initializer > Depends on, nl80211: add VHT support for set_bitrate_mask Good, I need to always know this. I now merged wireless-next to ath-next to get the dependency included. > --- a/drivers/net/wireless/ath/ath10k/wmi.h > +++ b/drivers/net/wireless/ath/ath10k/wmi.h > @@ -3003,6 +3003,24 @@ struct wmi_vdev_install_key_arg { > const void *key_data; > }; > > +/* > + * CCK: 0 - 11Mbps, 1 - 5,5Mbps, 2 - 2Mbps, 3 - 1Mbps, > + * 4 - 11Mbps (s), 5 - 5,5Mbps (s), 6 - 2Mbps (s) > + * OFDM: 0 - 48Mbps, 1 - 24Mbps, 2 - 12Mbps, 3 - 6Mbps, > + * 4 - 54Mbps, 5 - 36Mbps, 6 - 18Mbps, 7 - 9Mbps > + * HT/VHT: MCS index > + */ > +struct wmi_vdev_fixed_rate { > + union { > + u8 rate; > + struct { > + u8 preamble:2, /* %WMI_RATE_PREAMBLE_ */ > + nss:2, > + rate_mcs:4; /* see above */ > + } __packed; > + } __packed; > +} __packed; Bitfields are frowned upon in kernel, better to use SM() and MS(). -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html