Hello Johannes, Please allow me to clarify here. So the field "interference_source" in the struct "cfg80211_avoid_frequency_range" is not being effectively used currently. That field was added per suggestion from Luis for future use. But if you are advising to remove it then yes we can remove that field. The API cfg80211_avoid_frequency_event() which is introduced in this patch shall be used by our WLAN driver which is an open source driver. WLAN driver shall invoke this event API to pass frequency information to WPA Supplicant. We also have a patch ready for WPA supplicant which Jouni would upstream once kernel patch is blessed and up streamed. I will remove field "interference_source" and send revised patch and also incorporate your other comments. Pl. do let us know if you still see any issue. Regards, Rajesh Chauhan -----Original Message----- From: Johannes Berg [mailto:johannes@xxxxxxxxxxxxxxxx] Sent: Wednesday, December 04, 2013 12:21 AM To: Luis R. Rodriguez Cc: Chauhan, Rajesh; linux-wireless; Malinen, Jouni; BAHINI, Henri; Johnson, Jeff; Chang, Leo; Luo, Xun; Thalappil, Sameer; Hussain, Arif Subject: Re: [PATCHv3] cfg80211: add support for frequency interference event On Wed, 2013-12-04 at 09:20 +0100, Johannes Berg wrote: > On Tue, 2013-12-03 at 17:35 +0100, Luis R. Rodriguez wrote: > > On Tue, Dec 3, 2013 at 2:25 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > >> + * @interference_source: enum nl80211_freq_interference_source_type > > >> + * is used to specify source of interference. > > > > > > Do we expect that different sources would be treated differently? > > > If not, what use is this? > > > > That was because of my nagging, without such a field the type of > > interference would be completely ambiguous and we'd have no users on > > the Linux kernel of this API, > > Wait, we have no users for this API? Forget it then - I thought you > were going to post a patch soon. I guess I should have learned by now > not to trust QCA with this. > > I'll drop this until I see a patch using it. You can see this as a carrot (or stick, depending on how you look at it) for upstreaming the driver that wants it. johannes ��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
