On Wed, 2013-12-18 at 10:19 +0100, Johannes Berg wrote:
> On Wed, 2013-12-18 at 00:16 -0800, Joe Perches wrote:
>
> > Perhaps the
> > u8 tim[sizeof...]
> > member should be marked
> > __aligned(sizeof(unsigned long))
> > so that the cast to ulong when bitmap_empty
> > is actually forced to be ulong aligned?
>
> yeah, I suppose that's true.
>
> > diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h
> > index ed5bf8b..e5a9c51 100644
> > --- a/net/mac80211/ieee80211_i.h
> > +++ b/net/mac80211/ieee80211_i.h
> > @@ -245,7 +245,8 @@ struct ps_data {
> > /* yes, this looks ugly, but guarantees that we can later use
> > * bitmap_empty :)
> > * NB: don't touch this bitmap, use sta_info_{set,clear}_tim_bit */
> > - u8 tim[sizeof(unsigned long) * BITS_TO_LONGS(IEEE80211_MAX_AID + 1)];
> > + u8 tim[sizeof(unsigned long) * BITS_TO_LONGS(IEEE80211_MAX_AID + 1)]
> > + __aligned(sizeof(unsigned long));
>
> Care to send a proper patch? Otherwise I'll just re-do it and pick it up
> that way ...
Hi Johannes.
You can redo it easier than applying a patch
from me.
I just noticed it when the reformatting
patch went by.
No need to give a credit or anything.
It's just a nit.
cheers, Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
