2013/12/16 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> If you keep changing your patch without any changelog (after the "---"
> line!) then I have no idea what I should look at?
Right, I will add history of changes.
> > + if (rdev->num_running_ifaces == 1) {
> > + /* Last running AP iface*/
>
> missing a space
Yes, right.
> > + wdev_lock(wdev_iter);
>
> This will almost certainly cause a lockdep warning since you hold the
> wdev lock already.
>
> > + if (!netif_running(wdev_iter->netdev)) {
> > + wdev_unlock(wdev_iter);
> > + continue;
> > + }
> > +
> > + if (wdev_iter->iftype == NL80211_IFTYPE_AP) {
> > + wdev_unlock(wdev_iter);
> > + return false;
> > + }
> > + wdev_unlock(wdev_iter);
>
> I don't think checking the iftype needs the lock (this lock - maybe
> rtnl) anyway?
I will remove lock here.
> johannes
Marek
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
