Arik, Thank you for catching this and passing it along. Yes, it is not non purpose. It is due to an error when I entered the changes. NL80211_STA_FLAG_NO_SA_QUERY_REQUIRED is the correct name, but it should have been that name from the beginning. I also noticed that I did not break the changes up between the two commits correctly. I have fixed that. I will now send out a new set of patch files for review. - Chet > On Tue, Dec 3, 2013 at 6:46 AM, Chet Lanctot <clanctot@xxxxxxxxxxxxxx> > wrote: >> This adds support for drivers that have AP SME integrated but do >> not implement the SA Query procedure that is part of Protected >> Management Frames (PMF, 802.11w). >> >> Instead, hostapd can be used to assist drivers that lack SA Query >> Procedure handling on their own by allowing them to specify this as >> a device capability flag. >> >> Also, a station flag is added to let hostapd indicate to the driver >> that the SA Query procedure is complete and the driver can process >> association requests from the station normally. > [...] >> * enum nl80211_feature_flags - device/driver features >> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c >> index 587ff84..14a14d4 100644 >> --- a/net/wireless/nl80211.c >> +++ b/net/wireless/nl80211.c >> @@ -3766,7 +3766,8 @@ int cfg80211_check_station_change(struct wiphy >> *wiphy, >> BIT(NL80211_STA_FLAG_ASSOCIATED) | >> BIT(NL80211_STA_FLAG_SHORT_PREAMBLE) | >> BIT(NL80211_STA_FLAG_WME) | >> - BIT(NL80211_STA_FLAG_MFP))) >> + BIT(NL80211_STA_FLAG_MFP) | >> + >> BIT(NL80211_STA_FLAG_SA_QUERY_REQUIRED))) > > I didn't really read the patch, but noticed you're adding > NL80211_STA_FLAG_SA_QUERY_REQUIRED here and changing it to > NL80211_STA_FLAG_NO_SA_QUERY_REQUIRED in the next one. > Pretty sure that's not on purpose :) > > Arik > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
