On 10/12/13 18:05, Eliad Peller wrote: > hi, > > On Tue, Dec 10, 2013 at 6:39 PM, Antonio Quartulli > <antonio@xxxxxxxxxxxxxx> wrote: >> I need to invoke ieee80211_iter_keys() from a periodic worker in a driver and >> therefore I would prefer to get rid of any of locks to avoid problems. >> These two patches try to use rcu lock to protect the iteration, but I'd like to >> get a feedback before sending this stuff as a patch :-) >> > at least iwlwifi might sleep inside the iterator, so you can't just > convert it to rcu (atomic). > mh, this "might sleep" could be an issue, ok. >> Moreover, why do we use list_for_each_entry_safe() is ieee80211_iter_keys() if >> the list cannot be altered (pointer to key is not passed to iter() so we should >> be sure that nobody is going to invoke list_del())? > > see the documentation of ieee80211_remove_key(): This function does not exist anymore -- Antonio Quartulli
Attachment:
signature.asc
Description: OpenPGP digital signature
