On 2013-12-09 19:03, Antonio Quartulli wrote: > On 09/12/13 16:59, Felix Fietkau wrote: > [...] >> +/** >> + * struct ieee80211_noa_data - holds temporary data for tracking P2P NoA state >> + * >> + * @next_tsf: TSF timestamp of the next absent state change >> + * @has_next_tsf: next absent state change event pending >> + * >> + * @absent: descriptor bitmask, set if GO is currently absent >> + */ > > why not providing the kerneldoc for all the fields? Even the more > obvious for you may not be so obvious for the next poor reader that has > to touch this code :-) The driver should not care about those, they're private for the mac80211 utility function. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html