On Thu, 2013-12-05 at 17:52 +0200, Arik Nemtsov wrote: > >> > But the whole thing was intended to catch buggy drivers :) > >> > > >> yeah, you have a point here :) > >> anyway, i guess it's either leaking scan_req and hoping the driver > >> really forgot about it, or keeping it and hoping the driver will > >> finally indicate completion. > >> > >> since i don't think this is a real-world scenario, i'm ok with > >> dropping this patch. > > > > Well, it can be made to crash, so ... > > > > Can we maybe avoid the crash in a different way? Disallow a new scan > > somehow? > > Maybe we should drop the whole netdev-notified doing ___cfg80211_scan_done? > I mean if a workaround for buggy drivers is causing bugs for > legitimate drivers.. > > Something simple for buggy drivers would be doing this in the notifier > - BUG_ON(!rdev->scan_req->notified) BUG_ON is probably a bit heavy-handed, but yeah, I suppose we can drop this. We used to have more bugs with drivers and even mac80211, but that should be a thing of the past. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
