Search Linux Wireless

Re: [PATCH 4/4] nl80211: add VHT support for set_bitrate_mask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-12-03 at 09:50 +0100, Janusz Dziedzic wrote:
> Add VHT mcs support for nl80211_set_tx_bitrate_mask().

Do we really need more fine-grained control than 0-7/8/9? Why do we need
this at all? :)

> +#define NL80211_MAX_SUPP_VHT_RATES		80

Where does 80 come from? That seems odd?

> + * @NL80211_TXRATE_VHT_MCS: VHT (MCS) rates allowed for TX rate selection
> + *	in an array of MCS numbers.

VHT has no "MCS numbers", so this doesn't make much sense?

>  		if (mask.control[band].legacy == 0) {
> -			/* don't allow empty legacy rates if HT
> +			/* don't allow empty legacy rates if HT and VHT
>  			 * is not even supported. */

probably should say "are not" now :)

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux