Search Linux Wireless

Re: [PATCH v3] staging: vt6656: mac.c MACvWriteMultiAddr: Remove secondary variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-11-26 at 20:45 +0000, Malcolm Priestley wrote:
> Covert to pointer, point to callers buffer and remove casting in callers.
[]
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
[]
> @@ -1394,8 +1394,8 @@ static void device_set_multi(struct net_device *dev)
>              mc_filter[bit_nr >> 5] |= cpu_to_le32(1 << (bit_nr & 31));

A possible thing to fix for another day:

mc_filter is u32 but should probably be __le32 instead.
ORing a u32 and a cpu_to_le32 isn't ideal.


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux