Search Linux Wireless

Re: [PATCH 2/2] mac80211: Add support for QoS mapping

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-11-20 at 12:29 +0200, Jouni Malinen wrote:

> +++ b/net/mac80211/iface.c
> @@ -636,6 +636,8 @@ int ieee80211_do_open(struct wireless_dev *wdev, bool coming_up)
>  		ieee80211_set_wmm_default(sdata, true);
>  	}
>  
> +	sdata->qos_map.valid = false;

This isn't really needed for the first ifup (everything will be zero)
and seems insufficient for any later changes since iftype can change and
we should probably clear this on disassoc etc.

Might be better to handle that in cfg80211 to make it consistent, but
then you don't really need to set valid to false at all (never mind the
fact that I think valid should just go away :) )

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux