Search Linux Wireless

Re: [PATCH 3/3] wireless: rt2x00: remove unnecessary pci_set_drvdata()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 25, 2013 at 2:52 AM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>

Acked-by: Gertjan van Wingerde <gwingerde@xxxxxxxxx>

> ---
>  drivers/net/wireless/rt2x00/rt2x00pci.c |    3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00pci.c b/drivers/net/wireless/rt2x00/rt2x00pci.c
> index 25da20e..af72183 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00pci.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00pci.c
> @@ -156,8 +156,6 @@ exit_release_regions:
>  exit_disable_device:
>         pci_disable_device(pci_dev);
>
> -       pci_set_drvdata(pci_dev, NULL);
> -
>         return retval;
>  }
>  EXPORT_SYMBOL_GPL(rt2x00pci_probe);
> @@ -177,7 +175,6 @@ void rt2x00pci_remove(struct pci_dev *pci_dev)
>         /*
>          * Free the PCI device data.
>          */
> -       pci_set_drvdata(pci_dev, NULL);
>         pci_disable_device(pci_dev);
>         pci_release_regions(pci_dev);
>  }
> --
> 1.7.10.4
>
>



-- 
---
Gertjan
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux