Michal Kazior <michal.kazior@xxxxxxxxx> writes:
>> - /* FIXME: Hopefully this is a temporary measure.
>> - *
>> - * Reporting individual A-MSDU subframes means each reported frame
>> - * shares the same sequence number.
>> - *
>> - * mac80211 drops frames it recognizes as duplicates, i.e.
>> - * retransmission flag is set and sequence number matches sequence
>> - * number from a previous frame (as per IEEE 802.11-2012: 9.3.2.10
>> - * "Duplicate detection and recovery")
>> - *
>> - * To avoid frames being dropped clear retransmission flag for all
>> - * received A-MSDUs.
>> - *
>> - * Worst case: actual duplicate frames will be reported but this should
>> - * still be handled gracefully by other OSI/ISO layers. */
>> - hdr->frame_control &= cpu_to_le16(~IEEE80211_FCTL_RETRY);
>> -
>> first = skb;
>> while (skb) {
>> void *decap_hdr;
>>
>
> You're missing RX_FLAG_AMSDU_MORE. All subframes (except the last one)
> from an A-MSDU that are reported separately must have the bit set in
> status->flag. Only then mac80211 can apply retransmission/duplication
> check properly.
I'll send v2, thanks for the review.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
