On Mon, 2013-11-11 at 15:57 +0100, Simon Wunderlich wrote:
> > A beacon should never have a Channel Switch Announcement information
> > element with a count of 0, because a count of 1 means switch just
> > before the next beacon. So, if a count of 0 was valid in a beacon, it
> > would have been transmitted in the next channel already, which is
> > useless. A CSA count equal to zero is only meaningful in action
> > frames or probe_responses.
> >
> > Fix the ieee80211_csa_is_complete() and ieee80211_update_csa()
> > functions accordingly.
>
> Just to make future bisecting easier, shouldn't this patch go after "only set
> CSA beacon when at least one beacon must be transmitted" in the series?
> Otherwise userspace may change the channel with count=0 and hit a warning
> here, because this is not supported anymore.
My plan was to squash them, because they really belong together. What
do you think?
> Apart from that, the series looks fine. I'd like to test the next v4 then.
Great! I'll try to send v4 soon, hopefully the missing mesh part doesn't
turn out to be too complicated. ;)
> I guess we still need to do the action frame part - for IBSS mode we already
> have code but we probably need to make sure that these packets go out before
> actually changing the channel. Do you plan to work on that?
Yes, I'll look into it. I think it should be pretty simple, especially
now that we already have IBSS and MESH sending it out.
> Thanks for your work. :)
Thanks for your help! ;)
--
Luca.
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
