Search Linux Wireless

Re: [PATCH v4] mac80211: fix the mesh channel switch support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-11-08 at 15:09 +0800, Chun-Yeow Yeoh wrote:
> Mesh STA receiving the mesh CSA action frame is not able to trigger
> the mesh channel switch due to the incorrect handling and comparison
> of mesh channel switch parameters element (MCSP)'s TTL. Make sure
> the MCSP's TTL is updated accordingly before calling the
> ieee80211_mesh_process_chnswitch. Also, we update the beacon before
> forwarding the CSA action frame, so MCSP's precedence value and
> initiator flag need to be updated prior to this.

I guess I'll apply this.

>  		pre_value = cpu_to_le16(ifmsh->pre_value);
>  		memcpy(pos, &pre_value, 2);		/* Precedence Value */
>  		pos += 2;

However, it seems to me that you should be using put_unaligned_le16() or
so in places like this - maybe clean them all up?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux