Hello. On 10-11-2013 23:06, Michal Nazarewicz wrote:
From: Michal Nazarewicz <mina86@xxxxxxxxxx>
inta is checked to be zero in a IRQ_NONE branch so afterwards it cannot be zero as it is never modified.
Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx> --- drivers/net/wireless/iwlwifi/pcie/rx.c | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/pcie/rx.c b/drivers/net/wireless/iwlwifi/pcie/rx.c index 3f237b4..c32122a 100644 --- a/drivers/net/wireless/iwlwifi/pcie/rx.c +++ b/drivers/net/wireless/iwlwifi/pcie/rx.c
[...]
@@ -1150,7 +1149,13 @@ static irqreturn_t iwl_pcie_isr(int irq, void *data) * or due to sporadic interrupts thrown from our NIC. */ if (!inta) { IWL_DEBUG_ISR(trans, "Ignore interrupt, inta == 0\n"); - goto none; + /* re-enable interrupts here since we don't have anything to + * service. only Re-enable if disabled by irq and no + * schedules tasklet. */
The preferred way of formatting the multi-line comments in the networking code is this:
/* bla * bla */ WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html