On Wed, 2013-11-06 at 23:07 +0100, Arend van Spriel wrote:
> The SleepCSR register is accessed to wakeup the device from the
> host side. Depending on the state of the device this may take
> multiple attempts. The failed attempt are not real failures so
> reduce the log level specifically for this register. The calling
> function will scream when the multiple attempts all failed.
[]
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh_sdmmc.c
[]
> + if (err_ret) {
Maybe better as:
if (err_ret && net_ratelimit()) { ?
> + /*
> + * SleepCSR register access can fail when
> + * waking up the device so reduce this noise
> + * in the logs.
> + */
> + if (regaddr != SBSDIO_FUNC1_SLEEPCSR)
> + brcmf_err("Failed to %s byte F%d:@0x%05x=%02x, Err: %d\n",
> + rw ? "write" : "read", func, regaddr, *byte,
> + err_ret);
> + else
> + brcmf_dbg(SDIO, "Failed to %s byte F%d:@0x%05x=%02x, Err: %d\n",
> + rw ? "write" : "read", func, regaddr, *byte,
> + err_ret);
> + }
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
