Search Linux Wireless

Re: [PATCH 05/19] cfg80211: processing core regulatory hints on its own

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 6, 2013 at 2:24 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> On Tue, 2013-11-05 at 09:18 -0800, Luis R. Rodriguez wrote:
>
>>       struct wiphy *wiphy = NULL;
>> +     enum reg_request_treatment treatment;
>
> This
>
>>       if (WARN_ON(!reg_request->alpha2))
>>               return;
>> @@ -1552,7 +1580,18 @@ static void reg_process_hint(struct regulatory_request *reg_request)
>>               return;
>>       }
>>
>> -     switch (__regulatory_hint(wiphy, reg_request)) {
>> +     switch (reg_request->initiator) {
>> +     case NL80211_REGDOM_SET_BY_CORE:
>> +             reg_process_hint_core(reg_request);
>> +             return;

Note that for the core request we bail out early.

>> +     case NL80211_REGDOM_SET_BY_USER:
>> +     case NL80211_REGDOM_SET_BY_DRIVER:
>> +     case NL80211_REGDOM_SET_BY_COUNTRY_IE:
>> +             treatment = __regulatory_hint(wiphy, reg_request);
>> +             break;
>> +     }
>> +
>> +     switch (treatment) {
>
> is used uninitialized here

As I see it in the code we either bail early or its assigned to the
return value of __regulatory_hint() for the non-core case. Did I miss
something?

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux