On Sunday 17 February 2008 18:11:43 Johannes Berg wrote: > Looks good, thanks for your patience. thanks for your review :) > I have two minor comments still, > sorry for the lack of focus in earlier review. > > > + } else if (local && local->ops && local->ops->get_tsf) > > + /* second best option: get current TSF */ > > + rx_timestamp = local->ops->get_tsf(local_to_hw(local)); > > This is assuming that we don't manage to process the frame within 192 > usecs. I guess that will be true since we defer it to a tasklet, but do > we want to bet on it in the future or should we simply widen the window > where the merge *won't* happen because the driver doesn't provide enough > info and also add the 24 bytes offset here? true. i'll change that and resend the patch. i have to rebase it anyways for the current tree. > Also something else that just occurred to me... You wrote in the > > description: > > * to enable this we have to let all beacons thru in IBSS mode, even if > > they have a different BSSID. > > which I think refers to the last hunk of your patch. However, hardware > also has such filters, so I think we also should set the > FIF_BCN_PRBRESP_PROMISC filter flag when IBSS is enabled, we don't want > to force drivers to do this implicitly when IBSS interfaces are added. hmm, i don't know about that and i don't seem to need that for ath5k, so can we do that in a follow up patch, please? bruno - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
