Search Linux Wireless

Re: [PATCH 1/1] WDEV: ath5k, test single chip before reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/15/2008 10:53 PM, Nick Kossifidis wrote:
2008/2/15, Jiri Slaby <jirislaby@xxxxxxxxx>:
Move ath5k_hw_nic_wakeup after ah_single_chip being set, because we
 test the value in there and decides whether reset or not.

 Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
 Cc: Nick Kossifidis <mickflemm@xxxxxxxxx>
 Cc: Luis R. Rodriguez <mcgrof@xxxxxxxxx>
 ---
  drivers/net/wireless/ath5k/hw.c |   21 ++++++++++-----------
  1 files changed, 10 insertions(+), 11 deletions(-)

 diff --git a/drivers/net/wireless/ath5k/hw.c b/drivers/net/wireless/ath5k/hw.c
 index 3a4bf40..9cdd27f 100644
 --- a/drivers/net/wireless/ath5k/hw.c
 +++ b/drivers/net/wireless/ath5k/hw.c
[...]
 @@ -210,12 +205,13 @@ struct ath5k_hw *ath5k_hw_attach(struct ath5k_softc *sc, u8 mac_version)
        }

        /* Identify single chip solutions */
 -       if((srev <= AR5K_SREV_VER_AR5414) &&
 -       (srev >= AR5K_SREV_VER_AR2424)) {
 -               ah->ah_single_chip = true;
 -       } else {
 -               ah->ah_single_chip = false;
 -       }
 +       ah->ah_single_chip = srev >= AR5K_SREV_VER_AR2424 &&
 +                       srev <= AR5K_SREV_VER_AR5414;
 +
 +       /* Bring device out of sleep and reset it's units */
 +       ret = ath5k_hw_nic_wakeup(ah, AR5K_INIT_MODE, true);
 +       if (ret)
 +               goto err_free;

        /* Single chip radio */
        if (ah->ah_radio_2ghz_revision == ah->ah_radio_5ghz_revision)


NACK, single chip flag is going out since only needed check is for
5424/2424 during nic_wakeup, 5413/2413 behave like the rest
5211/5212-combatible cards.

Ok, thanks.

Sorry for delaying the relevant patches, i'm working with the 2413
card i got from Mike to make it work and it'll take some time (not as
easy as i thought, i probably miss something)...

No problem, if I could do anything for you in this area, don't hesitate to drop a message.
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux