On Mon, Oct 14, 2013 at 10:16 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Fri, 2013-10-11 at 11:29 -0700, Chun-Yeow Yeoh wrote:
>
>> /* Channel Switching Support */
>> + struct cfg80211_csa_settings *csa_settings;
>
> That should have an __rcu annotation now, I believe?
>
>> + if (ifmsh->csa_settings) {
>
> In which case this will result in a sparse warning.
>
> Does this even make sense here - it can't ever be non-NULL in this
> patch?
Actually, the NULL and non-NULL situation should occur here. Whenever
the node triggers the channel switching period, it will append CSA and
MCSP elements in the beacon. So in this case, ifmsh->csa_settings
should be non-NULL. Once the channel switching count based on TBTT is
expired, ifmsh->csa_setting should be NULL, and both elements no
longer append to the beacon. Does it make sense?
---
Chun-Yeow
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
