On Wed, 2013-10-02 at 17:33 -0700, Chun-Yeow Yeoh wrote:
> +int ieee80211_mesh_finish_csa(struct ieee80211_sub_if_data *sdata)
> +{
> + struct ieee80211_if_mesh *ifmsh = &sdata->u.mesh;
> + struct cfg80211_csa_settings *tmp_csa_settings;
> + int ret = 0;
> +
> + /* Remove the CSA and MCSP elements from the beacon */
> + tmp_csa_settings = rcu_dereference(ifmsh->csa_settings);
> + rcu_assign_pointer(ifmsh->csa_settings, NULL);
> + kfree(tmp_csa_settings);
This looks broken without kfree_rcu() or synchronize_rcu(), if it's OK
then at least add a comment? I think it's not OK though.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
